meta_pixel
Tapesearch Logo
Log in
Syntax - Tasty Web Development Treats

830: GitHub and Code Reviews with Sarah Vessels

Syntax - Tasty Web Development Treats

Wes Bos

Tech News, News, Technology

4.91.2K Ratings

🗓️ 4 October 2024

⏱️ 51 minutes

🧾️ Download transcript

Summary

Scott and Wes talk with GitHub’s Sarah Vessels about the ins and outs of code reviews, their critical role in collaborative development, and tips for making your reviews more effective. Show Notes 00:00 Welcome to Syntax! 00:59 What is a code review? How to review code effectively: A GitHub staff engineer’s philosophy 04:18 Strategies for an effective code review processes 06:59 Should you test and fix in the same pull request? 07:57 How to ask for code reviews 12:12 Feature flags and their role in code management flipper scientist scientist - JS 20:03 Who should do code reviews? 23:34 Should you review your own code? 25:04 Brought to you by Sentry.io 25:29 Code comments vs pull requests 27:35 Dealing with egos in the code review process 30:18 What automations are essential? project-pull-mover 34:35 Underutilized tools GitHub Protips: Tips, tricks, hacks, and secrets from Sarah Vessels 36:25 Commit strategies and squash 39:30 GitHub’s branching system 41:14 Git gone wrong 42:30 What is the correct way to merge into main? 43:47 What was it like working on GitHub Sponsors? GitHub Sponsors thanks.dev 46:58 Sick Picks & Shameless Plugs Sick Picks Sarah: https://store.steampowered.com/steamdeck Shameless Plugs Sarah: https://github.com/sponsors Hit us up on Socials! Syntax: X Instagram Tiktok LinkedIn Threads Wes: X Instagram Tiktok LinkedIn Threads Scott: X Instagram Tiktok LinkedIn Threads Randy: X Instagram YouTube Threads

Transcript

Click on a timestamp to play from that location

0:00.0

Welcome to Syntax. On today's supper club, we have Sarah vessels from

0:04.9

GitHub here. She's a staff software engineer, GitHub, and she's been there for

0:09.2

eight years working on all kinds of things like get hub sponsors discussions branch renaming

0:14.8

pin repositories private graph contributions and a ton of stuff and we're going to be

0:19.3

talking a lot about code reviews we're going going to be talking about GitHub the process of

0:25.2

emerging code in a project and working in a collaborative environment. My name is

0:30.3

Scott Tolinsky, with me as always is Wes.

0:32.5

Welcome to the show, Sarah.

0:34.7

Hi, thanks for having me on.

0:37.0

Yeah, so code reviews.

0:39.5

We have a lot of developers who listen to this show,

0:42.1

and maybe they haven't been a part of big teams or they've been

0:45.8

a part of big teams or you know they haven't done this process of a code review.

0:50.8

I read a blog post of yours that was extremely good. We'll link to it in the

0:55.2

show about the process of code reviews and I kind of wanted to start off there. So could you explain

1:01.5

two developers who might not be aware you know what's the deal with a code review? What's the premise? Why would somebody do a code review and what does that entail?

1:09.0

Okay, so code review is having your team, having other people with context on what you're trying to build,

1:16.4

the bug you're trying to fix, anything you're doing in a repository, getting them to look over your changes.

1:22.3

This is assuming you're using like pull requests, merge requests,

1:25.3

if you're on GetLAP, that you're not just throwing your code out there to the main branch.

1:30.8

So it's part of the process. I think you might have automated testing. You might have

1:34.8

automated deploys to some kind of staging environment. Stuff like that to help you assess, like, did I do the right thing?

...

Please login to see the full transcript.

Disclaimer: The podcast and artwork embedded on this page are from Wes Bos, and are the property of its owner and not affiliated with or endorsed by Tapesearch.

Generated transcripts are the property of Wes Bos and are distributed freely under the Fair Use doctrine. Transcripts generated by Tapesearch are not guaranteed to be accurate.

Copyright © Tapesearch 2026.